Send proxy_name to teleport #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
force-pushed
the
ox/send_proxy_name_to_teleport
branch
from
1a64060 to
d1b9b71
Compare
oxtoacart
force-pushed
the
ox/send_proxy_name_to_teleport
branch
from
d1b9b71 to
895b616
Compare
orca-glo
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
lgtm. thanks, @oxtoacart!
? optional... maybe also change includeProxyIdentity -> includeProxyName in configureOTEL for consistency with the change in buildOTELOpts?
oxtoacart
force-pushed
the
ox/send_proxy_name_to_teleport
branch
from
37a8238 to
bf1c7ac
Compare
oxtoacart
force-pushed
the
ox/send_proxy_name_to_teleport
branch
from
bf1c7ac to
96ca7d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be really useful to have proxy_name in Teleport so that we can group by that to see the distribution of performance per proxy, etc.
As long as we don't permanently track an association from proxy_name to public IP anywhere (i.e. if route information is deleted after we retire routes), then this is probably okay from a privacy perspective.