Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependencies #589

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Cleanup dependencies #589

merged 3 commits into from
Oct 25, 2023

Conversation

myleshorton
Copy link
Collaborator

@myleshorton myleshorton commented Oct 25, 2023

Update to various latest versions, primarily of our own repos, both to keep things up to date and to resolve issues importing http-proxy-lantern particularly from flashlight:

github.com/getlantern/flashlight/integrationtest imports
	github.com/getlantern/http-proxy-lantern/v2 imports
	github.com/getlantern/http-proxy-lantern/v2/otel imports
	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp imports
	go.opentelemetry.io/otel/exporters/otlp/internal: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal
github.com/getlantern/flashlight/integrationtest imports
	github.com/getlantern/http-proxy-lantern/v2 imports
	github.com/getlantern/http-proxy-lantern/v2/otel imports
	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp imports
	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/internal/oconf imports
	go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig

@myleshorton
Copy link
Collaborator Author

Bringing this in...

@myleshorton myleshorton merged commit 8d69878 into main Oct 25, 2023
1 check passed
@myleshorton myleshorton deleted the myles/dependency-cleanup branch October 25, 2023 12:06
@myleshorton
Copy link
Collaborator Author

For posterity, the reason the dependency tree was a little screwy was because go mod tidy was looking for the latest tag, which was on an older version. The "fix" was just to tag the latest. tbc this is running a fresh go mod init and go mod tidy from flashlight, which, if your dependency tree is clean, should result in a working copy. In this case, it grabbed an old http-proxy-lantern, resulting in the above error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant