Fix cert and key reading for broflake on lantern cloud #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwh33
approved these changes
Sep 6, 2024
http-proxy/main.go
Outdated
Comment on lines
474
to
476
| // TODO (allan): Remove BroflakeCert and BroflakeKey once broflake is working properly on LC | ||
| BroflakeCert: os.Getenv("BROFLAKE_CERT"), | ||
| BroflakeKey: os.Getenv("BROFLAKE_KEY"), |
There was a problem hiding this comment.
Sorry, I don't understand why we would want to leave these around. The fields are not referenced anymore and there will never be anything in those environment variables at this point.
Crosse
approved these changes
Sep 6, 2024
broflake/broflake.go
Outdated
Comment on lines
11
to
12
| // TODO: update the Broflake library to accept cert and key as PEM encoded strings | ||
| // TODO (allan): update the Broflake library to accept cert and key as PEM encoded strings | ||
| // Maybe it's already done. Investigate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.