Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mismatch protocol listener to water #629

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Adding mismatch protocol listener to water #629

merged 9 commits into from
Oct 29, 2024

Conversation

WendelHime
Copy link
Contributor

This PR adds a mismatch protocol flag to the WATER protocol. Currently this is specifically used for testing the integration between a flashlight client using a WASM file and a http-proxy running a listener that can be a go implementation or a WASM WATER implementation.

@WendelHime WendelHime changed the title Adding mismatch protocol to water Adding mismatch protocol listener to water Oct 22, 2024
Copy link
Contributor

@hwh33 hwh33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of very minor things, but looks good!

http_proxy.go Outdated Show resolved Hide resolved
http_proxy.go Outdated Show resolved Hide resolved
@WendelHime WendelHime marked this pull request as ready for review October 29, 2024 15:28
Copy link
Contributor

@hwh33 hwh33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@WendelHime WendelHime merged commit e15efa2 into main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants