use previous geolookup for ios #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just did some quick testing: the country is still AF for me when I submit an issue report. I'm seeing this in the logs: |
jigar-f
reviewed
Dec 17, 2024
There was a problem hiding this comment.
I had to call geolookup.Refresh() before GetCountry, now it works
jigar-f
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since iOS uses it's own code to fetch proxy configs instead of the grouped request, it's unable to retrieve geolocation. This PR adds the old geolookup code exclusively for iOS to use.
The
geolookuppackage was copied directly from flashlight's old geolookup package.