Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security assessment fixes #1275

Merged
merged 4 commits into from
Dec 31, 2024
Merged

Security assessment fixes #1275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e485c62
Remove DebugProbesKt.bin from prod apk.
jigar-f Dec 25, 2024
252b65c
Remove unused permisson.
jigar-f Dec 25, 2024
c9836d9
Update proguard-rules.pro
jigar-f Dec 25, 2024
32e5d70
Added read media permssion.
jigar-f Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ android {
}
// Use legacy packaging to helps reduce apk size
packagingOptions{
exclude "DebugProbesKt.bin"
jniLibs {
useLegacyPackaging true
}
Expand Down Expand Up @@ -356,8 +357,7 @@ dependencies {

implementation files('libs/opuslib-release.aar')
implementation 'com.github.getlantern:secrets-android:f6a7a69f3d'
// implementation 'com.github.getlantern:db-android:6c0525eeb9'
// implementation 'com.github.getlantern:messaging-android:eabf104396'


implementation 'com.github.getlantern:db-android:a137a028d4'
implementation 'com.github.getlantern:messaging-android:4c346e64ee'
Expand Down
1 change: 0 additions & 1 deletion android/app/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,4 +219,3 @@
##---------------Begin: proguard configuration for Signal ----------
-keep class org.whispersystems.** { *; }
##---------------End: proguard configuration for Signal ----------
#
7 changes: 5 additions & 2 deletions android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
<uses-permission android:name="android.permission.VIBRATE" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any of these permissions: READ_MEDIA_IMAGES, READ_MEDIA_VIDEO, or READ_MEDIA_AUDIO particularly for Replica?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, I tested replica downloading and uploading it seems to be working without that permission, Just for a safe bet, I added these permissions.


<uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />
<uses-permission android:name="android.permission.READ_MEDIA_VIDEO" />
<uses-permission android:name="android.permission.READ_MEDIA_AUDIO" />

<!-- Re-enable for Chat!
<uses-permission android:name="android.permission.RECORD_AUDIO" />
<uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS"/>
Expand Down
Loading