Fix errors detected by fdscan to improve user-perceived crash rate #886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/getlantern/engineering/issues/201
fdsan is a file descriptor sanitizer added to Android in API level 29. It detects mishandling of file descriptor ownership, which tends to manifest as use-after-close and double-close errors.
In the GoTun2SocksProvider class, we use VpnService.Builder.establish() to create the TUN device and return a file descriptor the application uses to access IP packets on it. tun2socks takes ownership of this file descriptor and closes it whenever ipproxy is stopped.
However, whenever the VPN is turned off, we are also calling ParcelFileDescriptor.close(). Given the fd is already closed, fdscan complains that we're double closing it. By calling
detachFd
instead ofgetFd
, we can detach the file descriptor from the ParcelFileDescriptor object