-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Appium test to install app from Play store with Lantern running #906
Conversation
Ok with Browserstack CI fixed, checking if the test runs successfully now. |
The test is failing for some reason:
|
I fixed that issue: I realized we could launch the Google Play app using the existing Android driver without having to create a second instance |
I'm able to run the full test now using a local Appium server with.. ./gradlew test --tests '*GooglePlay*' I didn't realize it was necessary to make changes to local_config.json to get all this to work. To save others trouble in the future, I updated the README with instructions for running the Appium tests locally. |
@ atavism I see tests are still failing on Browerstack, the issue is that Dart-define values are not being passed to Flutter, and enableFlutterDriverExtension is not enabled. Should we go ahead and create a new product flavor for the Appium test? What do you think let me know, I am open to other suggestions. Also, Let's keep in mind that we might need to few more changes for IOS as well, but that is for later not right now. |
468c31e
to
775eeea
Compare
Is this still an issue? We are passing CI=true via dart defines for debug builds: https://github.com/getlantern/android-lantern/blob/main/Makefile#L302
Yeah, sounds good to me! |
Yes, That is still an issue, somehow when running from CI dart-define not getting, While building we are getting logs but flutter not picking up, You can find full logs in CI.
Also let's create a card for Appium flavor |
@jigar-f https://github.com/getlantern/engineering/issues/460 |
Adding this test to help us debug https://github.com/getlantern/engineering/issues/223 further and it should be extremely useful
Here's how the test currently works (with Lantern running)..
Not ready for review yet, I need to check how the test runs