Stop using JSON across Go/Swift boundary and use pathdb's built-in support for protobuf #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport for protobuf
oxtoacart
force-pushed
the
ox/ios-migrate/pathdb-changes
branch
from
8c37efa to
8008c1d
Compare
oxtoacart
changed the title
oxtoacart
commented
Oct 11, 2023
| err := pathdb.Mutate(m.db, func(tx pathdb.TX) error { | ||
| pathdb.Put[string](tx, SERVER_COUNTRY, p1, "") | ||
| pathdb.Put[string](tx, SERVER_CITY, p0, "") | ||
| pathdb.Put[string](tx, SERVER_COUNTRY_CODE, p2, "") | ||
| pathdb.Put[bool](tx, HAS_SUCCEEDING_PROXY, p5, "") | ||
| pathdb.Put[[]byte](tx, PATH_SERVER_INFO, serverInfoBytes, "") | ||
| pathdb.Put[*ServerInfo](tx, PATH_SERVER_INFO, serverInfo, "") |
There was a problem hiding this comment.
Because we registered *ServerInfo with pathdb, we can directly Put it with having to marshal it ourselves. We don't do this, but we could also directly Get it without having to handle the protocol buffer unmarshalling ourselves.
|
Thanks @oxtoacart, I did see this in Kotlin, But I thought this was not supported on pathDb, Thanks for letting me know. |
|
I am going to test this PR and let you know the result. |
It wasn't fully supported, but it was supposed to be, so I fixed pathdb. |
|
@oxtoacart All changes are working fine, If you are done with PR, I like to merge it. |
|
Thanks @jigar-f ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were using JSON to send subscription results from Go to Swift. In addition to having some overhead, this also complicated the code a bit. This PR removes JSON in favor of just using Go objects that can be bound with gomobile.
The other change that this makes is to rely on pathdb's built-in support for protocol buffers. That built-in support wasn't complete, so I made some updates to pathdb, notably the
Raw.ValueOrProtoBytes()method. Going forward, when we want to store new protobuf types in the database, we just need to register them like thisYou'll notice that the existing Android application follows this same pattern with
db-android.Saved 154 lines of code too :)