fix navigation issue #938
Merged
fix navigation issue #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atavism I think we might need to merge the same fix for Android as well. |
atavism
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue on navigation while ConnectivityWarning is on.
The problem
We applied the 'Transform' widget to shift the appearance of buttons on the AppBar, making them look relocated. However, their actual 'clickable' zones didn't move with them. This caused confusion — users clicked where they saw the buttons, but nothing happened because the real, responsive part of the button hadn't moved and was hidden behind a warning message displayed in its place.