Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle for AGP 8.0 support #952

Closed
wants to merge 5 commits into from

Conversation

atavism
Copy link
Contributor

@atavism atavism commented Nov 20, 2023

Upgrading to AGP 8.0 seems to improve build times significantly. https://android-developers.googleblog.com/2022/10/prepare-your-android-project-for-agp8-changes.html

A couple Flutter plugins need to be made AGP 8.0 compliant as well before this can be merged

@atavism atavism changed the title Update build.gradle for AGP 8 support AGP 8.0 support Nov 20, 2023
@atavism atavism changed the title AGP 8.0 support Update build.gradle for AGP 8.0 support Nov 20, 2023
@jigar-f
Copy link
Contributor

jigar-f commented Nov 20, 2023

@ atavism The last time we tried this, we had issues with the CAS plugin.

@atavism
Copy link
Contributor Author

atavism commented Nov 20, 2023

@ atavism The last time we tried this, we had issues with the CAS plugin.

Yeah, that's the main one we need a workaround for to be able to upgrade. I think we should find some way to, if possible, since AGP 8.0 came out last year now

@jigar-f
Copy link
Contributor

jigar-f commented Nov 20, 2023

@atavism Cool, Let me ask the CAS team, they might be able to help us, Could you try upgrading the plugin (if any new version) and see if we still get the same error?

@@ -68,9 +68,9 @@ dependencies:
dio: ^5.3.2

# change this with flutter_downloader
flutter_uploader: ^3.0.0-beta.3
flutter_uploader: ^3.0.0-beta.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atavism moving forward I think we should switch this plugin to https://pub.dev/packages/flutter_downloader

@atavism atavism closed this Feb 27, 2024
@atavism atavism mentioned this pull request Mar 13, 2024
This was referenced Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants