Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing go:embed directive for sysproxy binary #16

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Add missing go:embed directive for sysproxy binary #16

merged 2 commits into from
Mar 19, 2023

Conversation

atavism
Copy link
Contributor

@atavism atavism commented Mar 6, 2023

@atavism atavism requested a review from soltzen March 6, 2023 17:08
@atavism
Copy link
Contributor Author

atavism commented Mar 7, 2023

I confirmed I'm able to run Lantern on Ubuntu 22.10 with these changes. Lantern successfully sets itself as system proxy:

image

@atavism atavism requested a review from myleshorton March 7, 2023 16:42
soltzen
soltzen approved these changes Mar 8, 2023
View reviewed changes
Copy link

@soltzen soltzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atavism
Copy link
Contributor Author

atavism commented Mar 8, 2023

Thanks for the review, @soltzen!

@myleshorton
Copy link
Contributor

LGTM! Let's go ahead and merge, as this is unrelated to the libayatana issues mentioned here https://github.com/getlantern/lantern-desktop/pull/323

@myleshorton myleshorton merged commit 63a8cac into main Mar 19, 2023
@myleshorton myleshorton deleted the atavism/fix-sysproxy-issue-ubuntu branch March 19, 2023 11:06
@atavism
Copy link
Contributor Author

atavism commented Mar 19, 2023

Thanks, @myleshorton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltzen soltzen soltzen approved these changes

@myleshorton myleshorton myleshorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lantern can't used in Ubuntu 20.04, how to solve it?
3 participants
@atavism @myleshorton @soltzen