-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add KMS methods for Key Rotations and MACs #8462
base: master
Are you sure you want to change the base?
Conversation
Implemented New Methods: - rotate_key_on_demand - list_key_rotations Added these already implemented methods as dummies to the Backend so they show up in the coverage: - list_key_policies - generate_random
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8462 +/- ##
========================================
Coverage 92.62% 92.63%
========================================
Files 1225 1225
Lines 105655 105792 +137
========================================
+ Hits 97865 97996 +131
- Misses 7790 7796 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The two lines missing coverage are for the dummy methods to include |
Hi @MauriceBrg, thanks for the PR! Just left two comments.
That will be either because Moto hasn't been updated in a while, or you're running the script with an outdated version of
I'm OK with the current approach. Having 100% coverage is a nice to have, but in the end, it doesn't functionally change anything. We have an implementation, and we have tests for it - that's all I care about. |
…E.md and simplify the verify_mac implementation
Hey @bblommers thanks for the suggestions, I have updated the code to address them and removed the update I've updated boto3 and botocore, now the
|
Implemented New Methods for KMS:
generate_mac
rotate_key_on_demand
list_key_rotations
verify_mac
Added these already implemented methods as dummies to the Backend so they show up in the coverage:
list_key_policies
generate_random
(When I ran
scripts/implementation_coverage.py
it also updated a bunch of other rst-files (>50) with new methods, I'm not sure if I should commit those as well, as most are unrelated to KMS)