Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis resource based policy implementation #8463

Merged
merged 7 commits into from
Jan 4, 2025

Conversation

jerryhxu
Copy link
Contributor

@jerryhxu jerryhxu commented Jan 3, 2025

Fixes #8465

@jerryhxu jerryhxu marked this pull request as ready for review January 4, 2025 03:41
@jerryhxu jerryhxu changed the title Kinesis resource policies Kinesis resource based policy implementation Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (ec277aa) to head (30b0c7f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8463   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files        1225     1225           
  Lines      105655   105685   +30     
=======================================
+ Hits        97865    97895   +30     
  Misses       7790     7790           
Flag Coverage Δ
servertests 27.75% <23.33%> (-0.01%) ⬇️
unittests 92.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you the PR @jerryhxu, and welcome to Moto!

@bblommers bblommers added this to the 5.0.26 milestone Jan 4, 2025
@bblommers bblommers merged commit 1eadeeb into getmoto:master Jan 4, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kinesis: resource based policies
2 participants