SecretsManager: list_secrets() now properly splits words when filtering #8469
+197
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8421
The documentation states that when filtering by e.g. name or description, the search happens by
Prefix match
.When filtering by
all
(that is, name and description and tags), search approach is:Until now Moto would split values by spaces (
my test
-> [my
,test
]), but AWS uses upper case letters to recognize words (MyTest
-> [My
,Test
]).Testing this feature showed that filtering by
description
would also break it into words - it is not a prefix match, as the docs state.Also introduces proper case insensitivity for the
description
andall
filters.All new tests are verified against AWS.