Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SESV2 - Configuration Sets & Dedicated IP Pools #8479

Merged
merged 13 commits into from
Jan 12, 2025

Conversation

zkarpinski
Copy link
Contributor

@zkarpinski zkarpinski commented Jan 9, 2025

Adds support for Configuration Sets & Dedicated IP Pools for SESv2. (#8472 )

  • Shared backend with SES
  • Updated SES Configuration Set implementation

SESv2 Additions

  • CreateConfigurationSet
  • GetConfigurationSet
  • ListConfigurationSets
  • DeleteConfigurationSet
  • CreateDedicatedIpPool
  • GetDedicatedIpPool
  • ListDedicatedIpPools
  • DeleteDedicatedIpPool

@zkarpinski zkarpinski marked this pull request as ready for review January 9, 2025 17:11
@zkarpinski zkarpinski changed the title Support for SESV2 - Configuration Sets [WIP] Support for SESV2 - Configuration Sets Jan 9, 2025
@zkarpinski zkarpinski changed the title Support for SESV2 - Configuration Sets Support for SESV2 - Configuration Sets & Dedicated IP Pools Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 99.21260% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (699b55e) to head (f233e1f).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
moto/ses/models.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8479    +/-   ##
========================================
  Coverage   92.62%   92.63%            
========================================
  Files        1225     1225            
  Lines      105708   105906   +198     
========================================
+ Hits        97916    98109   +193     
- Misses       7792     7797     +5     
Flag Coverage Δ
servertests 27.75% <29.92%> (+<0.01%) ⬆️
unittests 92.61% <99.21%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thank you @zkarpinski!

@bblommers bblommers added this to the 5.0.27 milestone Jan 12, 2025
@bblommers bblommers merged commit 07cb7f7 into getmoto:master Jan 12, 2025
51 of 53 checks passed
@moto-payments-app
Copy link

Hi @zkarpinski,

Thank you for contributing to Moto!

To show our thanks, we'd like to share some of the donations that we've received with you. PR's like this are the big reason that Moto is as successful as it is - so it's only fair that you, as a contributor, get to share the spoils.

We've created a companion website with more information:
https://payments.getmoto.org/

Feel free to open a bug or discussion if you run into any problems:
https://github.com/getmoto/payments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants