RDS: refactoring .get() calls in test cases

[snordhausen]

Slightly simplifying the test case for RDS, continuation of #8461.

[snordhausen]

Test failures seem unrelated to my code changes.

[bpandola]

@snordhausen I don't have any problem with this, but just curious: what was the motivation? Save a few characters and make things a bit more tidy, or is there some larger issue here?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (699b55e) to head (4e9df4e).
Report is 12 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #8483    +/-   ##
========================================
  Coverage   92.62%   92.63%            
========================================
  Files        1225     1225            
  Lines      105708   105918   +210     
========================================
+ Hits        97916    98120   +204     
- Misses       7792     7798     +6     

Flag	Coverage Δ
servertests	27.76% <ø> (+<0.01%)	⬆️
unittests	92.61% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[snordhausen]

@bpandola The goal is to reduce code complexity.

foo = bar.get("batz")

is equivalent to

foo = bar["batz"] if "batz" in bar else None

I'm replacing that with

foo = bar["batz"]

which eliminates the complexity of one if-else-statement.

Additionally, most test cases look like

foo = bar.get("batz")
assert foo["abc"] == "xyz"

If the batz key actually does not exist, the error becomes apparent only in line 2 with an error message NoneType object is not subscriptable. One needs to read both line 1 and line 2 to understand that error. But with

foo = bar["batz"]
assert foo["abc"] == "xyz"

line 1 will raise a KeyError. To understand the error, one only needs to read a single line of code.

So in summary, the .get() increases code complexity and obscures certain errors.