Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Allow replace/remove of mocked responses #8499

Merged
merged 1 commit into from
Jan 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions moto/core/responses_custom_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,23 @@
self._registered[response.method].append(response)
return response

def replace(self, response: responses.BaseResponse) -> responses.BaseResponse:
registered = self._registered[response.method]
try:
index = registered.index(response)
except ValueError:
raise ValueError(f"Response is not registered for URL {response.url}")

Check warning on line 40 in moto/core/responses_custom_registry.py

View check run for this annotation

Codecov / codecov/patch

moto/core/responses_custom_registry.py#L39-L40

Added lines #L39 - L40 were not covered by tests
registered[index] = response
return response

def remove(self, response: responses.BaseResponse) -> List[responses.BaseResponse]:
removed_responses = []
registered = self._registered[response.method]
while response in registered:
registered.remove(response)
removed_responses.append(response)

Check warning on line 49 in moto/core/responses_custom_registry.py

View check run for this annotation

Codecov / codecov/patch

moto/core/responses_custom_registry.py#L48-L49

Added lines #L48 - L49 were not covered by tests
return removed_responses

def reset(self) -> None:
self._registered.clear()

Expand Down
21 changes: 21 additions & 0 deletions tests/test_core/test_request_mocking.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
from unittest import SkipTest

import boto3
import pytest
import requests
from responses import Response

from moto import mock_aws, settings
from moto.core.models import responses_mock


@mock_aws
Expand Down Expand Up @@ -48,3 +52,20 @@ def test_decorator_ordering() -> None:

resp = requests.get(presigned_url)
assert resp.status_code == 200


@mock_aws()
def test_replace_and_remove_mock() -> None:
if not settings.TEST_DECORATOR_MODE:
raise SkipTest("Only need to test responses mock in decorator mode")
rsp1 = Response(method="GET", url="http://example.com", body="test")
responses_mock.add(rsp1)

assert requests.get("http://example.com/").text == "test"

rsp2 = Response(method="GET", url="http://example.com", body="test2")
responses_mock.replace(rsp2)

assert requests.get("http://example.com/").text == "test2"

responses_mock.remove("GET", "https://example.com/")
Loading