DynamoDB: Support ReturnValuesOnConditionCheckFailure for all op types in transact_write_items #8522
+71
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in transact_write_items
cameron-toy
force-pushed
the
return_all_op
branch
from
be17005 to
e447ca8
Compare
|
Updated branch to fix linting issue |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8522 +/- ##
==========================================
- Coverage 92.63% 92.62% -0.01%
==========================================
Files 1224 1229 +5
Lines 105980 106399 +419
==========================================
+ Hits 98170 98555 +385
- Misses 7810 7844 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
approved these changes
Feb 2, 2025
There was a problem hiding this comment.
Nice! Looks like this simplifies the implementation quite a bit. Thank you for this PR @cameron-toy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8516
Tested locally and in AWS via
MOTO_TEST_ALLOW_AWS_REQUESTflag