Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretsManager: list_secrets() now filters values with special chars correctly #8529

Merged

Conversation

bblommers
Copy link
Collaborator

@bblommers bblommers commented Jan 27, 2025

Followup to #8469, words are now also split by special characters (/, +, and a few others).

Fixes #8421

Whether this is the final form of this algorithm, I don't know - it's quite possible that I've missed some use cases. It is currently closer to AWS parity than before though, with the (AWS-validated) tests to prove it.

@bblommers bblommers added this to the 5.0.28 milestone Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (69a3669) to head (ad4d632).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
moto/secretsmanager/list_secrets/filters.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8529      +/-   ##
==========================================
- Coverage   92.63%   92.63%   -0.01%     
==========================================
  Files        1224     1229       +5     
  Lines      105980   106414     +434     
==========================================
+ Hits        98170    98572     +402     
- Misses       7810     7842      +32     
Flag Coverage Δ
servertests 27.92% <81.81%> (+0.17%) ⬆️
unittests 92.60% <95.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers marked this pull request as ready for review January 28, 2025 18:42
@bblommers bblommers merged commit 6ad9786 into getmoto:master Jan 28, 2025
53 checks passed
@bblommers bblommers deleted the secretsmanager-split-by-special-chars branch January 28, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecretsManager List Secrets Filter with Key all deviated from boto3
1 participant