Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB: return ConsumedCapacity on delete_item #8530

Merged

Conversation

rick-soptim
Copy link
Contributor

Extends the changes from #4241 to the DDB DeleteItem endpoint.

DeleteItem-Responses should include an ConsumedCapacity element in the same way as Scan-, Query-, GetItem- and PutItem-Responses already do: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_DeleteItem.html#DDB-DeleteItem-response-ConsumedCapacity

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (16abebb) to head (2b6545e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8530   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files        1229     1229           
  Lines      106394   106395    +1     
=======================================
+ Hits        98553    98554    +1     
  Misses       7841     7841           
Flag Coverage Δ
servertests 27.91% <100.00%> (+<0.01%) ⬆️
unittests 92.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers changed the title fix: return ConsumedCapacity on delete_item DynamoDB: return ConsumedCapacity on delete_item Jan 28, 2025
@bblommers bblommers added this to the 5.0.28 milestone Jan 28, 2025
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thank you for fixing this @rick-soptim

@bblommers bblommers merged commit 11addde into getmoto:master Jan 28, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants