-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies V2 Playground #2099
Draft
carolynvs
wants to merge
21
commits into
getporter:main
Choose a base branch
from
carolynvs:dependencies-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
dependencies-v2
branch
2 times, most recently
from
May 31, 2022 19:54
a0c3603
to
58dc1e8
Compare
carolynvs
added
the
playground 🙈
Pull request to try stuff out and see if it builds. Don't look!
label
Jun 30, 2022
carolynvs
added
the
pep003-advanced-dependencies
Implementation of the Advanced Dependencies proposal
label
Jul 5, 2022
4 tasks
Closed
carolynvs
force-pushed
the
dependencies-v2
branch
3 times, most recently
from
September 1, 2022 02:33
63215d9
to
2bb25ad
Compare
carolynvs
force-pushed
the
dependencies-v2
branch
from
September 11, 2022 01:00
876c3e4
to
fe4c28d
Compare
carolynvs
force-pushed
the
dependencies-v2
branch
from
October 24, 2022 20:46
fe4c28d
to
03d23e4
Compare
carolynvs
force-pushed
the
dependencies-v2
branch
from
October 25, 2022 21:34
b4234e9
to
dcddace
Compare
carolynvs
force-pushed
the
dependencies-v2
branch
2 times, most recently
from
November 14, 2022 23:16
bb1397e
to
924fb4a
Compare
carolynvs
force-pushed
the
dependencies-v2
branch
4 times, most recently
from
December 24, 2022 05:20
5f004f5
to
2fe2c7f
Compare
This adds support for the dependencies-v2 experimental flag when building a bundle. * Add dependency v2 fields to the porter.yaml manifest * Represent v2 deps in the bundle.json * Determine which dependency extension is used by a bundle * Have separate packages for the dependencies v2 cnab extension, and its implementation * Consolidate extensions definition into a single file * Match file names to contained structs in pkg/cnab Signed-off-by: Carolyn Van Slyck <[email protected]>
The name field for a dependency is not in the spec because CNAB represents a dependency as a map entry, keyed by name. We use a name internally just to make things easier while working with dependency entries but they shouldn't be written out with a name field. Signed-off-by: Carolyn Van Slyck <[email protected]>
mybuns = a test bundle that contains as many features / test cases we can squeeze into a bundle, without making a bunch of paramters required so that it's easy to run. Long term I want to remove dependencies from this bundle though and switch to using a new set of bundles just for dependencies. myenv = a metabundle that is comprised of its dependencies. Has a deep dependency graph. myinfra = a bundle that creates infrastructure and generates outputs that parent bundles would want to consume. myapp = a bundle that deploys an application and requires a db connection string mydb = a leaf bundle that creates a db and outputs a connection string Signed-off-by: Carolyn Van Slyck <[email protected]>
* resolve a dependency graph * identify the order of execution * create new call path to execute bundles from a workflow (i.e. jobs) * Add secret strategy for resolving data from the workflow * Support workflow wiring Signed-off-by: Carolyn Van Slyck <[email protected]> wip: porter strategy Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
…wrong format still Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
This should ideally go into the open PR Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
dependencies-v2
branch
from
February 12, 2023 03:03
503e285
to
aae9178
Compare
Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
…igure it out Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
Add a DisplayWorkflow structure that can represent a workflow and also remove non-user settable fields so that we can dump our plans without including status, ids, etc. Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
* hacks to force rebuild test bundles * porter secret store isn't implemented. Is that hiding on a branch somewhere? Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
…a should match then Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pep003-advanced-dependencies
Implementation of the Advanced Dependencies proposal
playground 🙈
Pull request to try stuff out and see if it builds. Don't look!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just where I'm trying out how we could implement advanced dependencies scenarios pep, which would be v2 of the CNAB dependencies extension.
Right now I'm working on getting Porter set up so that we can hide this behind a feature flag so that we can incrementally work on it before v1 releases.