Allow resolving a subset of the values in a value set #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichristensen
force-pushed
the
subsetResolve
branch
3 times, most recently
from
f341e7a to
a3217c3
Compare
…credentials - Update ResolveAll to accept a list of required credential keys - Add Keys() method to CredentialSet to get list of credential names - Filter credentials during resolution to only process required ones - Update credential provider interface and implementations Signed-off-by: Kim Christensen <[email protected]>
- Add Keys() method to ParameterSet to get parameter names - Update ResolveAll signature to accept list of required parameter keys - Modify parameter resolution to skip parameters not in requested keys - Update all parameter resolution calls to pass required keys Signed-off-by: Kim Christensen <[email protected]>
…nd lookup - Add GetCredential helper method to CredentialSet for safe credential lookup - Remove slices dependency in favor of direct credential lookup - Add tracing spans for better observability - Improve error messages with proper error wrapping - Change resolution logic to iterate through requested keys instead of all credentials Signed-off-by: Kim Christensen <[email protected]>
…place updates - Change GetCredential signature to return *secrets.SourceMap instead of value - Update loadCredentials to use Keys() iterator for credential lookup - Add explicit error handling for missing credentials - Fix credential value updates to modify original values via pointers Signed-off-by: Kim Christensen <[email protected]>
- Update ResolveAll to return ErrorOrNil() instead of raw error group - Ensures consistent error handling when no errors occurred during resolution Signed-off-by: Kim Christensen <[email protected]>
kichristensen
force-pushed
the
subsetResolve
branch
from
a3217c3 to
d791029
Compare
Signed-off-by: Kim Christensen <[email protected]>
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
kichristensen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Allows us the only resolve a subset of the values, which can be used to increase security and reducing number of API calls.
Currently all existing calls still resolves the whole set, this can be improved in a future PR.
What issue does it fix
Closes #2609
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist