feat(pattern): Handle empty alternatives #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
reviewed
Nov 22, 2024
loewenheim
force-pushed
the
feat/pattern-optional
branch
from
e3ccb70 to
43b8415
Compare
loewenheim
force-pushed
the
feat/pattern-optional
branch
from
651db10 to
6d4eec6
Compare
loewenheim
changed the title
loewenheim
changed the title
jjbayer
reviewed
Nov 25, 2024
Dav1dde
approved these changes
Nov 25, 2024
Co-authored-by: David Herberth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
Optionalvariant ofTokenthat optionally matches the contained list of tokens. These optional tokens are parsed from alternations containing empty branches, e.g.{foo,bar,}(note the trailing comma).