feat: Remove hooks related code, which is not used (#126)

We do not use this, so removing this reduces some overhead & bundle size.
getsentry · Apr 26, 2024 · 7a31a7e · 7a31a7e
1 parent 49fec35
commit 7a31a7e
Show file tree

Hide file tree

Showing 3 changed files with 125 additions and 242 deletions.
diff --git a/packages/rrweb/src/record/index.ts b/packages/rrweb/src/record/index.ts
@@ -90,7 +90,6 @@ function record<T = eventWithTime>(
     maskAttributeFn,
     maskInputFn,
     maskTextFn,
-    hooks,
     packFn,
     sampling = {},
     dataURLOptions = {},
@@ -454,130 +453,127 @@ function record<T = eventWithTime>(
     const handlers: listenerHandler[] = [];
 
     const observe = (doc: Document) => {
-      return callbackWrapper(initObservers)(
-        {
-          onMutation,
-          mutationCb: wrappedMutationEmit,
-          mousemoveCb: (positions, source) =>
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source,
-                positions,
-              },
-            }),
-          mouseInteractionCb: (d) =>
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source: IncrementalSource.MouseInteraction,
-                ...d,
-              },
-            }),
-          scrollCb: wrappedScrollEmit,
-          viewportResizeCb: (d) =>
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source: IncrementalSource.ViewportResize,
-                ...d,
-              },
-            }),
-          inputCb: (v) =>
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source: IncrementalSource.Input,
-                ...v,
-              },
-            }),
-          mediaInteractionCb: (p) =>
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source: IncrementalSource.MediaInteraction,
-                ...p,
-              },
-            }),
-          styleSheetRuleCb: (r) =>
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source: IncrementalSource.StyleSheetRule,
-                ...r,
-              },
-            }),
-          styleDeclarationCb: (r) =>
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source: IncrementalSource.StyleDeclaration,
-                ...r,
-              },
-            }),
-          canvasMutationCb: wrappedCanvasMutationEmit,
-          fontCb: (p) =>
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source: IncrementalSource.Font,
-                ...p,
-              },
-            }),
-          selectionCb: (p) => {
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source: IncrementalSource.Selection,
-                ...p,
-              },
-            });
-          },
-          customElementCb: (c) => {
-            wrappedEmit({
-              type: EventType.IncrementalSnapshot,
-              data: {
-                source: IncrementalSource.CustomElement,
-                ...c,
-              },
-            });
-          },
-          blockClass,
-          ignoreClass,
-          ignoreSelector,
-          maskAllText,
-          maskTextClass,
-          unmaskTextClass,
-          maskTextSelector,
-          unmaskTextSelector,
-          maskInputOptions,
-          inlineStylesheet,
-          sampling,
-          recordDOM,
-          recordCanvas,
-          inlineImages,
-          userTriggeredOnInput,
-          collectFonts,
-          doc,
-          maskAttributeFn,
-          maskInputFn,
-          maskTextFn,
-          keepIframeSrcFn,
-          blockSelector,
-          unblockSelector,
-          slimDOMOptions,
-          dataURLOptions,
-          mirror,
-          iframeManager,
-          stylesheetManager,
-          shadowDomManager,
-          processedNodeManager,
-          canvasManager,
-          ignoreCSSAttributes,
-          plugins: [],
+      return callbackWrapper(initObservers)({
+        onMutation,
+        mutationCb: wrappedMutationEmit,
+        mousemoveCb: (positions, source) =>
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source,
+              positions,
+            },
+          }),
+        mouseInteractionCb: (d) =>
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source: IncrementalSource.MouseInteraction,
+              ...d,
+            },
+          }),
+        scrollCb: wrappedScrollEmit,
+        viewportResizeCb: (d) =>
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source: IncrementalSource.ViewportResize,
+              ...d,
+            },
+          }),
+        inputCb: (v) =>
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source: IncrementalSource.Input,
+              ...v,
+            },
+          }),
+        mediaInteractionCb: (p) =>
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source: IncrementalSource.MediaInteraction,
+              ...p,
+            },
+          }),
+        styleSheetRuleCb: (r) =>
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source: IncrementalSource.StyleSheetRule,
+              ...r,
+            },
+          }),
+        styleDeclarationCb: (r) =>
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source: IncrementalSource.StyleDeclaration,
+              ...r,
+            },
+          }),
+        canvasMutationCb: wrappedCanvasMutationEmit,
+        fontCb: (p) =>
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source: IncrementalSource.Font,
+              ...p,
+            },
+          }),
+        selectionCb: (p) => {
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source: IncrementalSource.Selection,
+              ...p,
+            },
+          });
         },
-        hooks,
-      );
+        customElementCb: (c) => {
+          wrappedEmit({
+            type: EventType.IncrementalSnapshot,
+            data: {
+              source: IncrementalSource.CustomElement,
+              ...c,
+            },
+          });
+        },
+        blockClass,
+        ignoreClass,
+        ignoreSelector,
+        maskAllText,
+        maskTextClass,
+        unmaskTextClass,
+        maskTextSelector,
+        unmaskTextSelector,
+        maskInputOptions,
+        inlineStylesheet,
+        sampling,
+        recordDOM,
+        recordCanvas,
+        inlineImages,
+        userTriggeredOnInput,
+        collectFonts,
+        doc,
+        maskAttributeFn,
+        maskInputFn,
+        maskTextFn,
+        keepIframeSrcFn,
+        blockSelector,
+        unblockSelector,
+        slimDOMOptions,
+        dataURLOptions,
+        mirror,
+        iframeManager,
+        stylesheetManager,
+        shadowDomManager,
+        processedNodeManager,
+        canvasManager,
+        ignoreCSSAttributes,
+        plugins: [],
+      });
     };
 
     iframeManager.addLoadListener((iframeEl) => {