Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export additional canvas-related types and functions #134

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Dec 5, 2023

We need these types/functions to replay canvas.

We need these types/functions to replay canvas. Also reverts the plugins code that were removed because we need that as well.
Copy link

github-actions bot commented Dec 5, 2023

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.62 KB (+0.13% 🔺)
rrweb - record & getCanvasManager only (gzipped) 22.74 KB (+0.85% 🔺)
rrweb - record only (min) 57.18 KB (0%)
rrweb - record with treeshaking flags (gzipped) 15.37 KB (+0.09% 🔺)

@billyvg billyvg marked this pull request as ready for review December 5, 2023 23:06
@billyvg billyvg requested a review from a team December 5, 2023 23:06
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lower-cased types make me sad, but it is what it is!

@billyvg billyvg merged commit 173fff1 into sentry-v2 Dec 7, 2023
2 checks passed
@billyvg billyvg deleted the feat-export-canvas-types-no-revert branch December 7, 2023 16:18
billyvg added a commit that referenced this pull request Apr 26, 2024
We need these types/functions to replay canvas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants