fix(rrweb): null check for pointer #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan953
reviewed
Jun 18, 2024
| @@ -2179,7 +2179,7 @@ export class Replayer { | |||
| private drawMouseTail(position: { x: number; y: number }, pointerId: number) { | |||
| const pointer = this.pointers[pointerId]; | |||
There was a problem hiding this comment.
This might be the trick to tell typescript that pointer could be null, then we'll get all the typehints:
Suggested change
| const pointer = this.pointers[pointerId]; | |
| const pointer = this.pointers.at(pointerId); |
There was a problem hiding this comment.
that gives me a lint error :(
Unsafe assignment of an `any` value.
There was a problem hiding this comment.
ooh, think pointers is a Record type, i assumed array without looking.
nbd.
ryan953
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes JAVASCRIPT-2TN6