Use new AGP api for native symbols upload #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
commented
Nov 7, 2023
plugin-build/src/test/kotlin/io/sentry/android/gradle/integration/SentryPluginTest.kt
Show resolved
Hide resolved
markushi
approved these changes
Nov 9, 2023
romtsn
commented
Nov 9, 2023
| @@ -273,8 +284,8 @@ private fun Variant.configureProguardMappingsTasks( | |||
| if (isAGP74) { | |||
| val variant = AndroidVariant74(this) | |||
| val sentryProps = getPropertiesFilePath(project, variant) | |||
| val guardsquareEnabled = extension.dexguardEnabled.get() | |||
| val isMinifyEnabled = isMinificationEnabled(project, variant, guardsquareEnabled) | |||
| val dexguardEnabled = extension.dexguardEnabled.get() | |||
There was a problem hiding this comment.
This slipped thru in the previous PR, so I just changed it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #109
💚 How did you test it?
Manually + automated
📝 Checklist
🔮 Next steps
SentryVariantlevel to have it abstracted away, and then we could even move everything to thecommonmodule and it could be shared between Android and Jvm plugins. Probably gonna be part of Support proguard mapping upload for any JVM app #403