Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: temporarily pin Dio in tests to a version that works with WASM #2145

Closed
wants to merge 1 commit into from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jul 4, 2024

The CI is currently broken because of Dio making a breaking change regarding WASM compatibility without a major version bump (See cfug/dio#2266 for some details.)

Currently, we cannot make a release because tests started to fail after the latest version was picked up in CI. We don't want to change the dependency constraint because most users aren't using WASM compilation so we don't want to prevent them from updating Dio. Pinning in tests to a lower version works fine.

💚 How did you test it?

CI passes

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@vaind vaind changed the title temporarily pin Dio in tests to a version that works with WASM ci: temporarily pin Dio in tests to a version that works with WASM Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (d20b867) to head (4faf42a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
+ Coverage   88.25%   95.04%   +6.79%     
==========================================
  Files         215        9     -206     
  Lines        7515      202    -7313     
==========================================
- Hits         6632      192    -6440     
+ Misses        883       10     -873     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaind vaind marked this pull request as ready for review July 4, 2024 12:21
@AlexV525
Copy link
Contributor

AlexV525 commented Jul 4, 2024

We've published Dio v5.5.0+1 to solve the issue.

@buenaflor
Copy link
Contributor

ci looks fine, guess we don't need this pr anymore

@vaind vaind closed this Jul 4, 2024
@vaind vaind deleted the vaind-patch-1 branch July 24, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants