Add Flutter runtime information #2742
Open
+107
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2742 +/- ##
==========================================
- Coverage 88.99% 88.98% -0.01%
==========================================
Files 263 263
Lines 8924 8925 +1
==========================================
Hits 7942 7942
- Misses 982 983 +1 ☔ View full report in Codecov by Sentry. |
ueman
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
ueman
commented
Feb 20, 2025
|
ohh nice! 🥳 |
ueman
commented
Feb 24, 2025
Comment on lines
18
to
22
| return SentryRuntime( | ||
| name: 'Flutter', | ||
| version: '${FlutterVersion.version} (${FlutterVersion.channel})', | ||
| build: FlutterVersion.frameworkRevision, | ||
| ); |
There was a problem hiding this comment.
Does it make sense to you to structure it like this?
ueman
commented
Feb 24, 2025
Comment on lines
+54
to
+57
| /// The URL of the Git repository from which Flutter was obtained. | ||
| static const String? gitUrl = bool.hasEnvironment('FLUTTER_GIT_URL') | ||
| ? String.fromEnvironment('FLUTTER_GIT_URL') | ||
| : null; |
There was a problem hiding this comment.
Should this be included in a context somewhere?
|
This PR is ready to review now, but maybe we should wait with merging a little to see whether the changes are sticking this time in the Flutter framework |
ueman
commented
Feb 24, 2025
|
@buenaflor The linked PR is sticking, so it should be safe to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fun fact: This fixes the oldest currently open issue in this repo
💡 Motivation and Context
#416
💚 How did you test it?
I'm not entirely sure how to test this, since Dart defines aren't mockable.
You can test this manually by switching to the master channel of Flutter and building an app.
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Wait until the Flutter PR is merged, then merge this.