Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass missing captureFailedRequests param to FailedRequestInterceptor #2744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Maatteogekko
Copy link

📜 Description

dio.addSentry() captureFailedRequest param passed through to FailedRequestInterceptor.

💡 Motivation and Context

Fixes #2737.

💚 How did you test it?

I have run the fix in my app and it works as expected.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (08aff50) to head (329722c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2744      +/-   ##
==========================================
+ Coverage   88.99%   95.04%   +6.05%     
==========================================
  Files         263        9     -254     
  Lines        8924      202    -8722     
==========================================
- Hits         7942      192    -7750     
+ Misses        982       10     -972     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Maatteogekko
Copy link
Author

Should I add the changelog entry like the failing job suggests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

captureFailedRequests not correctly passed to FailedRequestInterceptor
1 participant