Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move replay and privacy from experimental to options #2755

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 25, 2025

📜 Description

Move replay and privacy from experimental to options

💡 Motivation and Context

prep for v9

💚 How did you test it?

Run tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/screenshot/recorder.dart

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (bb29ef9) to head (87dfea8).
Report is 1 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2755      +/-   ##
==========================================
+ Coverage   88.49%   89.70%   +1.21%     
==========================================
  Files         262       91     -171     
  Lines        8750     2952    -5798     
==========================================
- Hits         7743     2648    -5095     
+ Misses       1007      304     -703     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase denrase requested a review from vaind February 25, 2025 16:20
@denrase denrase marked this pull request as ready for review February 25, 2025 16:20
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the changelog item

CHANGELOG.md Outdated
@@ -23,6 +23,7 @@
- Responses are attached to the `Hint` object, which can be read in `beforeSend`/`beforeSendTransaction` callbacks via `hint.response`.
- For now, only the `dio` integration is supported.
- Enable privacy masking for screenshots by default ([#2728](https://github.com/getsentry/sentry-dart/pull/2728))
- Move replay and privacy from experimental to options ([#2755](https://github.com/getsentry/sentry-dart/pull/2755))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go to a new Unreleased section in preparation for the next alpha

@@ -1,5 +1,9 @@
# Changelog

## 9.0.0 Unreleased

- Move replay and privacy from experimental to options ([#2755](https://github.com/getsentry/sentry-dart/pull/2755))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 9.0.0.
    Consider moving the entry to the ## Unreleased section, please.

@denrase denrase merged commit b06e562 into v9 Feb 26, 2025
54 of 56 checks passed
@denrase denrase deleted the v9-feat/move-replay-out-of-experimental branch February 26, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants