feat(deno): add Deno.serve integration #12460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brc-dd
commented
Jun 12, 2024
| @@ -488,7 +488,7 @@ jobs: | |||
| - name: Set up Deno | |||
| uses: denoland/[email protected] | |||
| with: | |||
| deno-version: v1.38.5 | |||
| deno-version: v1.x | |||
There was a problem hiding this comment.
jsr wasn't supported on deno 1.38. deno.land/std/... won't receive non-critical updates and jsr is the recommended way
if needed we can lock it to some minor
re-running CI should pass I guess 👀
brc-dd
commented
Jun 12, 2024
| return new Proxy(handler, { | ||
| apply(handlerTarget, handlerThisArg, handlerArgs: Parameters<RawHandler>) { | ||
| return withIsolationScope(isolationScope => { | ||
| isolationScope.clear(); |
There was a problem hiding this comment.
also this line should be removed when #12450 (comment) is resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12450
the code is mostly taken from the bun sdk
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).