Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set attribute if value is None #3816

Merged
merged 1 commit into from
Nov 22, 2024

dont set none as attr value

da58844
Select commit
Loading
Failed to load commit list.
Merged

Don't set attribute if value is None #3816

dont set none as attr value
da58844
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 22, 2024 in 0s

30.41% (-47.00%) compared to 5e822de

View this Pull Request on Codecov

30.41% (-47.00%) compared to 5e822de

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.41%. Comparing base (5e822de) to head (da58844).

Files with missing lines Patch % Lines
sentry_sdk/tracing.py 83.33% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5e822de) and HEAD (da58844). Click for more details.

HEAD has 97 uploads less than BASE
Flag BASE (5e822de) HEAD (da58844)
102 5
Additional details and impacted files
@@               Coverage Diff               @@
##           potel-base    #3816       +/-   ##
===============================================
- Coverage       77.40%   30.41%   -47.00%     
===============================================
  Files             140      140               
  Lines           14820    14633      -187     
  Branches         2376     2176      -200     
===============================================
- Hits            11472     4450     -7022     
- Misses           2675     9778     +7103     
+ Partials          673      405      -268     
Files with missing lines Coverage Δ
sentry_sdk/tracing.py 40.25% <83.33%> (-19.46%) ⬇️

... and 110 files with indirect coverage changes