(3.1) Implements Report a Bug button #4378
Conversation
Co-authored-by: Krystof Woldrich <[email protected]>
Co-authored-by: LucasZF <[email protected]>
…es not hide the scrollview buttons
…358-Feedback-Form-Autoinject
…8-Feedback-Form-Autoinject-Button
* Adds sentry branding logo as a base64 encoded png --------- Co-authored-by: LucasZF <[email protected]>
…358-Feedback-Form-Autoinject-Button # Conflicts: # packages/core/src/js/feedback/FeedbackForm.styles.ts # packages/core/src/js/feedback/FeedbackForm.types.ts # packages/core/src/js/index.ts # samples/react-native/src/Screens/ErrorsScreen.tsx
…358-Feedback-Form-Autoinject-Button # Conflicts: # CHANGELOG.md
…358-Feedback-Form-Autoinject-Button
…358-Feedback-Form-Autoinject-Button # Conflicts: # CHANGELOG.md
|
The latest |
Yep, It was based on the incomplete "autoinjection" that was reverted 😓 |
| * Shows the feedback form screen that sends feedback to Sentry using Sentry.captureFeedback. | ||
| * @param navigation The navigation object from React Navigation | ||
| */ | ||
| export const showFeedbackForm = (navigation: Navigation): void => { |
There was a problem hiding this comment.
I think we should avoid depending on specific navigation lib and enforcing specific screen name.
I imagine the auto injection to work when uset used Sentry.wrap(AppRoot) and then anywhere Sentry.showFeedbackForm() is called the form will show up (we can ensure using style it's on to of other content, it won't show as navigation, but I think that's acceptable).
But also I'm open to discuss the approach.
This will require to store the feedback options in the Sentry.init(options)
| * @beta | ||
| * Implements a feedback button that opens the feedback form screen to Sentry using Sentry.captureFeedback. | ||
| */ | ||
| export class FeedbackButton extends React.Component<FeedbackFormProps> { |
There was a problem hiding this comment.
The feedback button has still the form props.
|
I know this is still a draft, but I checked the code and added my thoughts. |
📢 Type of change
Depends on: #4370
📜 Description
Implements feedback button that launches the feedback form using the auto-injected feedback widget
💡 Motivation and Context
Fixes #4369
💚 How did you test it?
Manual testing with the sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog