Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Add native startWithConfigureOptions for Apple platforms #4444

Draft
wants to merge 1 commit into
base: kw-ref-ios-sdk-init
Choose a base branch
from

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 580590b

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 459.21 ms 453.18 ms -6.03 ms
Size 17.75 MiB 20.11 MiB 2.36 MiB

Baseline results on branch: kw-ref-ios-sdk-init

Startup times

Revision Plain With Sentry Diff
aca58c3 466.10 ms 450.37 ms -15.73 ms
650ad89 448.65 ms 437.68 ms -10.97 ms

App size

Revision Plain With Sentry Diff
aca58c3 17.75 MiB 20.11 MiB 2.36 MiB
650ad89 17.75 MiB 20.11 MiB 2.36 MiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 400.79 ms 464.06 ms 63.28 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: kw-ref-ios-sdk-init

Startup times

Revision Plain With Sentry Diff
aca58c3+dirty 390.15 ms 460.67 ms 70.52 ms
650ad89+dirty 317.38 ms 328.64 ms 11.26 ms

App size

Revision Plain With Sentry Diff
aca58c3+dirty 7.15 MiB 8.38 MiB 1.23 MiB
650ad89+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.82 ms 1228.17 ms -2.65 ms
Size 2.63 MiB 3.68 MiB 1.05 MiB

Baseline results on branch: kw-ref-ios-sdk-init

Startup times

Revision Plain With Sentry Diff
aca58c3+dirty 1233.37 ms 1239.63 ms 6.27 ms
650ad89+dirty 1231.02 ms 1239.31 ms 8.29 ms

App size

Revision Plain With Sentry Diff
aca58c3+dirty 2.63 MiB 3.68 MiB 1.05 MiB
650ad89+dirty 2.63 MiB 3.68 MiB 1.05 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.06 ms 1226.75 ms 10.69 ms
Size 3.19 MiB 4.25 MiB 1.06 MiB

Baseline results on branch: kw-ref-ios-sdk-init

Startup times

Revision Plain With Sentry Diff
aca58c3+dirty 1227.92 ms 1243.36 ms 15.44 ms
650ad89+dirty 1248.86 ms 1252.69 ms 3.84 ms

App size

Revision Plain With Sentry Diff
aca58c3+dirty 3.19 MiB 4.25 MiB 1.06 MiB
650ad89+dirty 3.19 MiB 4.25 MiB 1.06 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant