Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add unhandled rejection mechanism #4457

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Jan 16, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Unhandled rejection were lacking the Mechanism field, so I added it.

💡 Motivation and Context

#4093

💚 How did you test it?

Unit test and https://sentry-sdks.sentry.io/issues/6018946733/events/91e85dfdbd5340c487e7d279378441d4/?project=5428561

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@lucas-zimerman lucas-zimerman marked this pull request as ready for review January 16, 2025 18:16
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1241.52 ms 1234.18 ms -7.34 ms
Size 2.63 MiB 3.69 MiB 1.05 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c2a4e9b+dirty 1240.10 ms 1239.22 ms -0.88 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
db44eaf+dirty 1227.09 ms 1230.65 ms 3.56 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
8ab11b6+dirty 1203.23 ms 1206.02 ms 2.79 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms
83f6f6c+dirty 1218.33 ms 1220.27 ms 1.93 ms
4a6664f+dirty 1209.49 ms 1208.63 ms -0.86 ms
3aecc61+dirty 1237.75 ms 1237.42 ms -0.33 ms
52c0562+dirty 1219.34 ms 1221.25 ms 1.91 ms

App size

Revision Plain With Sentry Diff
c2a4e9b+dirty 2.36 MiB 3.08 MiB 734.00 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
db44eaf+dirty 2.36 MiB 3.10 MiB 755.81 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
8ab11b6+dirty 2.36 MiB 3.11 MiB 759.83 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB
83f6f6c+dirty 2.36 MiB 3.10 MiB 759.79 KiB
4a6664f+dirty 2.36 MiB 3.04 MiB 696.39 KiB
3aecc61+dirty 2.36 MiB 3.12 MiB 778.58 KiB
52c0562+dirty 2.36 MiB 3.14 MiB 793.36 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.84 ms 1213.61 ms -13.23 ms
Size 3.19 MiB 4.25 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c2a4e9b+dirty 1247.39 ms 1243.04 ms -4.35 ms
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
db44eaf+dirty 1238.49 ms 1236.56 ms -1.93 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
8ab11b6+dirty 1222.91 ms 1216.08 ms -6.83 ms
2534337+dirty 1220.87 ms 1221.47 ms 0.60 ms
83f6f6c+dirty 1232.02 ms 1229.15 ms -2.87 ms
4a6664f+dirty 1218.77 ms 1221.07 ms 2.30 ms
3aecc61+dirty 1240.27 ms 1240.51 ms 0.24 ms
52c0562+dirty 1233.94 ms 1226.29 ms -7.65 ms

App size

Revision Plain With Sentry Diff
c2a4e9b+dirty 2.92 MiB 3.64 MiB 739.91 KiB
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
db44eaf+dirty 2.92 MiB 3.66 MiB 761.15 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
8ab11b6+dirty 2.92 MiB 3.67 MiB 772.38 KiB
2534337+dirty 2.92 MiB 3.43 MiB 529.76 KiB
83f6f6c+dirty 2.92 MiB 3.67 MiB 772.37 KiB
4a6664f+dirty 2.92 MiB 3.60 MiB 702.09 KiB
3aecc61+dirty 2.92 MiB 3.69 MiB 789.88 KiB
52c0562+dirty 2.92 MiB 3.69 MiB 794.15 KiB

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 352.22 ms 343.33 ms -8.89 ms
Size 17.75 MiB 20.11 MiB 2.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
83f6f6c 418.83 ms 410.94 ms -7.89 ms
8c88ac7 411.15 ms 400.54 ms -10.60 ms
baa882f 354.93 ms 356.18 ms 1.25 ms
12427f4 393.69 ms 414.84 ms 21.14 ms
c830127 407.57 ms 409.50 ms 1.93 ms
5571a20 410.55 ms 441.06 ms 30.51 ms
700cbf4 425.56 ms 436.26 ms 10.70 ms
690220d 468.28 ms 480.06 ms 11.78 ms
75774ea 454.16 ms 467.80 ms 13.64 ms
800171e 479.44 ms 462.86 ms -16.58 ms

App size

Revision Plain With Sentry Diff
83f6f6c 17.74 MiB 20.09 MiB 2.35 MiB
8c88ac7 17.74 MiB 20.08 MiB 2.34 MiB
baa882f 17.73 MiB 20.06 MiB 2.33 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB
c830127 17.74 MiB 20.10 MiB 2.36 MiB
5571a20 17.73 MiB 19.93 MiB 2.19 MiB
700cbf4 17.73 MiB 20.07 MiB 2.33 MiB
690220d 17.74 MiB 20.08 MiB 2.35 MiB
75774ea 17.74 MiB 20.08 MiB 2.35 MiB
800171e 17.75 MiB 20.11 MiB 2.36 MiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 390.87 ms 433.86 ms 42.99 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 371.61 ms 390.00 ms 18.39 ms
9282172+dirty 363.57 ms 399.78 ms 36.20 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
5571a20+dirty 359.52 ms 389.80 ms 30.28 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
700cbf4+dirty 411.71 ms 485.52 ms 73.81 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms
abb7058+dirty 320.78 ms 324.08 ms 3.30 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
5f03ae9+dirty 375.36 ms 401.26 ms 25.90 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB
9282172+dirty 7.15 MiB 8.37 MiB 1.22 MiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
5571a20+dirty 7.15 MiB 8.20 MiB 1.05 MiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
700cbf4+dirty 7.15 MiB 8.34 MiB 1.19 MiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB
abb7058+dirty 7.15 MiB 8.10 MiB 980.40 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
5f03ae9+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants