Use REDIS_HOST in specs

getsentry · Feb 27, 2025 · b51ff06 · b51ff06
1 parent e6eba31
commit b51ff06
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/sentry-ruby/spec/sentry/breadcrumb/redis_logger_spec.rb b/sentry-ruby/spec/sentry/breadcrumb/redis_logger_spec.rb
@@ -3,7 +3,7 @@
 require "spec_helper"
 
 RSpec.describe :redis_logger do
-  let(:redis) { Redis.new(host: "127.0.0.1") }
+  let(:redis) { Redis.new(host: REDIS_HOST) }
 
   before do
     perform_basic_setup do |config|
@@ -20,7 +20,7 @@
       expect(result).to eq("OK")
       expect(Sentry.get_current_scope.breadcrumbs.peek).to have_attributes(
         category: "db.redis",
-        data: { commands: [{ command: "SET", key: "key" }], server: "127.0.0.1:6379/0" }
+        data: { commands: [{ command: "SET", key: "key" }], server: "#{REDIS_HOST}:6379/0" }
       )
     end
   end
@@ -34,7 +34,7 @@
       expect(result).to eq("OK")
       expect(Sentry.get_current_scope.breadcrumbs.peek).to have_attributes(
         category: "db.redis",
-        data: { commands: [{ command: "SET", key: "key", arguments: "value" }], server: "127.0.0.1:6379/0" }
+        data: { commands: [{ command: "SET", key: "key", arguments: "value" }], server: "#{REDIS_HOST}:6379/0" }
       )
     end
 
@@ -62,7 +62,7 @@
       expect(result.key?("uptime_in_days")).to eq(true)
       expect(Sentry.get_current_scope.breadcrumbs.peek).to have_attributes(
         category: "db.redis",
-        data: { commands: [{ command: "INFO", key: nil }], server: "127.0.0.1:6379/0" }
+        data: { commands: [{ command: "INFO", key: nil }], server: "#{REDIS_HOST}:6379/0" }
       )
     end
   end
@@ -88,7 +88,7 @@
             { command: "INCR",  key: "counter" },
             { command: "EXEC",  key: nil }
           ],
-          server: "127.0.0.1:6379/0"
+          server: "#{REDIS_HOST}:6379/0"
         }
       )
     end
@@ -105,7 +105,7 @@
       expect(result).to eq("OK")
       expect(Sentry.get_current_scope.breadcrumbs.peek).to have_attributes(
         category: "db.redis",
-        data: { commands: [{ command: "SET", key: "key" }], server: "127.0.0.1:6379/0" }
+        data: { commands: [{ command: "SET", key: "key" }], server: "#{REDIS_HOST}:6379/0" }
       )
     end
   end

diff --git a/sentry-ruby/spec/sentry/redis_spec.rb b/sentry-ruby/spec/sentry/redis_spec.rb
@@ -3,7 +3,7 @@
 require "spec_helper"
 
 RSpec.describe Sentry::Redis do
-  let(:redis) { Redis.new(host: "127.0.0.1") }
+  let(:redis) { Redis.new(host: REDIS_HOST) }
 
   context "with tracing enabled" do
     before do
@@ -33,7 +33,7 @@
           expect(request_span.data).to eq({
             "db.name" => 0,
             "db.system" => "redis",
-            "server.address" => "127.0.0.1",
+            "server.address" => REDIS_HOST,
             "server.port" => 6379
           })
         end

diff --git a/sentry-ruby/spec/spec_helper.rb b/sentry-ruby/spec/spec_helper.rb
@@ -18,6 +18,8 @@
   coverage_dir File.join(__FILE__, "../../coverage")
 end
 
+REDIS_HOST = ENV.fetch("REDIS_HOST", "127.0.0.1")
+
 if ENV["CI"]
   require 'simplecov-cobertura'
   SimpleCov.formatter = SimpleCov::Formatter::CoberturaFormatter