Fix issue with MaxBreadcrumbs setting is not respected on desktop
#688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Nov 18, 2024
|
@tustanivsky approved to unblock. We need some tests though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
sentry-nativedoesn't support working with multiple scopes we've added a custom scope class implementation for Windows/Linux to align the UE plugin API across different platforms (see #328).SentryScopeDesktopstores breadcrumbs in its own cache and thus ignoresMaxBreadcrumbssetting value provided during the Native SDK initialization. This PR adds a corresponding breadcrumbs amount check and changes the cache's container type to ringbuffer.Closes #683