test: Fix testing-library/no-wait-for-multiple-assertions violations

eslint.config.mjs

@@ -965,7 +965,6 @@ export default typescript.config([
       'testing-library/no-container': 'warn', // TODO(ryan953): Fix the violations, then delete this line
       'testing-library/no-node-access': 'warn', // TODO(ryan953): Fix the violations, then delete this line
       'testing-library/no-render-in-lifecycle': 'warn', // TODO(ryan953): Fix the violations, then delete this line
-      'testing-library/no-wait-for-multiple-assertions': 'warn', // TODO(ryan953): Fix the violations, then delete this line
       'testing-library/prefer-presence-queries': 'warn', // TODO(ryan953): Fix the violations, then delete this line
       'testing-library/prefer-query-by-disappearance': 'warn', // TODO(ryan953): Fix the violations, then delete this line
       'testing-library/prefer-screen-queries': 'warn', // TODO(ryan953): Fix the violations, then delete this line

static/app/components/contextPickerModal.spec.tsx

@@ -103,8 +103,8 @@ describe('ContextPickerModal', function () {
 
     await waitFor(() => {
       expect(fetchProjectsForOrg).toHaveBeenCalled();
-      expect(onFinish).toHaveBeenLastCalledWith('/test/org2/path/project2/');
     });
+    expect(onFinish).toHaveBeenLastCalledWith('/test/org2/path/project2/');
   });
 
   it('selects an org and calls `onFinish` with URL with organization slug', async function () {

static/app/components/events/autofix/autofixDiff.spec.tsx

@@ -125,8 +125,8 @@ describe('AutofixDiff', function () {
 
     await waitFor(() => {
       expect(screen.queryByTestId('line-added')).not.toBeInTheDocument();
-      expect(screen.queryByTestId('line-removed')).not.toBeInTheDocument();
     });
+    expect(screen.queryByTestId('line-removed')).not.toBeInTheDocument();
   });
 
   it('shows error message on failed edit', async function () {

static/app/components/events/eventAttachments.spec.tsx

@@ -188,7 +188,7 @@ describe('EventAttachments', function () {
     // Should make the delete request and remove the attachment optimistically
     await waitFor(() => {
       expect(deleteMock).toHaveBeenCalled();
-      expect(screen.queryByTestId('pic_1.png')).not.toBeInTheDocument();
     });
+    expect(screen.queryByTestId('pic_1.png')).not.toBeInTheDocument();
   });
 });

static/app/components/group/groupSummary.spec.tsx

@@ -54,12 +54,12 @@ describe('GroupSummary', function () {
 
     await waitFor(() => {
       expect(screen.getByText("What's wrong")).toBeInTheDocument();
-      expect(screen.getByText('Test whats wrong')).toBeInTheDocument();
-      expect(screen.getByText('In the trace')).toBeInTheDocument();
-      expect(screen.getByText('Test trace')).toBeInTheDocument();
-      expect(screen.getByText('Possible cause')).toBeInTheDocument();
-      expect(screen.getByText('Test possible cause')).toBeInTheDocument();
     });
+    expect(screen.getByText('Test whats wrong')).toBeInTheDocument();
+    expect(screen.getByText('In the trace')).toBeInTheDocument();
+    expect(screen.getByText('Test trace')).toBeInTheDocument();
+    expect(screen.getByText('Possible cause')).toBeInTheDocument();
+    expect(screen.getByText('Test possible cause')).toBeInTheDocument();
   });
 
   it('shows loading state', function () {
@@ -110,11 +110,11 @@ describe('GroupSummary', function () {
 
     await waitFor(() => {
       expect(screen.getByText("What's wrong")).toBeInTheDocument();
-      expect(screen.getByText('Test whats wrong')).toBeInTheDocument();
-      expect(screen.queryByText('In the trace')).not.toBeInTheDocument();
-      expect(screen.getByText('Possible cause')).toBeInTheDocument();
-      expect(screen.getByText('Test possible cause')).toBeInTheDocument();
     });
+    expect(screen.getByText('Test whats wrong')).toBeInTheDocument();
+    expect(screen.queryByText('In the trace')).not.toBeInTheDocument();
+    expect(screen.getByText('Possible cause')).toBeInTheDocument();
+    expect(screen.getByText('Test possible cause')).toBeInTheDocument();
   });
 
   it('renders in preview mode', async function () {
@@ -131,7 +131,7 @@ describe('GroupSummary', function () {
 
     await waitFor(() => {
       expect(screen.getByText("What's wrong")).toBeInTheDocument();
-      expect(screen.getByText('Test whats wrong')).toBeInTheDocument();
     });
+    expect(screen.getByText('Test whats wrong')).toBeInTheDocument();
   });
 });

static/app/components/group/tagFacets/index.spec.tsx

@@ -139,9 +139,9 @@ describe('Tag Facets', function () {
       );
       await waitFor(() => {
         expect(screen.getByRole('listitem', {name: 'os'})).toBeInTheDocument();
-        expect(screen.getByRole('listitem', {name: 'device'})).toBeInTheDocument();
-        expect(screen.getByRole('listitem', {name: 'release'})).toBeInTheDocument();
       });
+      expect(screen.getByRole('listitem', {name: 'device'})).toBeInTheDocument();
+      expect(screen.getByRole('listitem', {name: 'release'})).toBeInTheDocument();
     });
 
     it('expands first tag distribution by default', async function () {

static/app/components/organizations/pageFilters/container.spec.tsx

@@ -225,9 +225,9 @@ describe('PageFiltersContainer', function () {
 
     await waitFor(() => {
       expect(globalActions.updateDateTime).not.toHaveBeenCalled();
-      expect(globalActions.updateProjects).not.toHaveBeenCalled();
-      expect(globalActions.updateEnvironments).not.toHaveBeenCalled();
     });
+    expect(globalActions.updateProjects).not.toHaveBeenCalled();
+    expect(globalActions.updateEnvironments).not.toHaveBeenCalled();
 
     expect(PageFiltersStore.getState()).toEqual({
       isReady: true,

static/app/components/search/sources/apiSource.spec.tsx

@@ -398,8 +398,8 @@ describe('ApiSource', function () {
       // The return values here are because of fuzzy search matching.
       // There are no members that match
       expect(mock.mock.calls[1][0].results).toHaveLength(6);
-      expect(mock.mock.calls[1][0].results[0].item.model.slug).toBe('foo-org');
     });
+    expect(mock.mock.calls[1][0].results[0].item.model.slug).toBe('foo-org');
 
     mock.mockClear();
 
@@ -412,8 +412,8 @@ describe('ApiSource', function () {
     await waitFor(() => {
       // Still have 4 results, but is re-ordered
       expect(mock.mock.calls[0][0].results).toHaveLength(6);
-      expect(mock.mock.calls[0][0].results[0].item.model.slug).toBe('foo-team');
     });
+    expect(mock.mock.calls[0][0].results[0].item.model.slug).toBe('foo-team');
   });
 
   describe('API queries', function () {

static/app/components/searchQueryBuilder/index.spec.tsx

@@ -163,18 +163,18 @@ describe('SearchQueryBuilder', function () {
       // Should call onChange and onSearch after enter
       await waitFor(() => {
         expect(mockOnChange).toHaveBeenCalledTimes(1);
-        expect(mockOnChange).toHaveBeenCalledWith('ab', expectedQueryState);
-        expect(mockOnSearch).toHaveBeenCalledTimes(1);
-        expect(mockOnSearch).toHaveBeenCalledWith('ab', expectedQueryState);
       });
+      expect(mockOnChange).toHaveBeenCalledWith('ab', expectedQueryState);
+      expect(mockOnSearch).toHaveBeenCalledTimes(1);
+      expect(mockOnSearch).toHaveBeenCalledWith('ab', expectedQueryState);
 
       await userEvent.click(document.body);
 
       // Clicking outside activates onBlur
       await waitFor(() => {
         expect(mockOnBlur).toHaveBeenCalledTimes(1);
-        expect(mockOnBlur).toHaveBeenCalledWith('ab', expectedQueryState);
       });
+      expect(mockOnBlur).toHaveBeenCalledWith('ab', expectedQueryState);
     });
   });
 
@@ -194,8 +194,8 @@ describe('SearchQueryBuilder', function () {
 
       await waitFor(() => {
         expect(mockOnChange).toHaveBeenCalledWith('', expect.anything());
-        expect(mockOnSearch).toHaveBeenCalledWith('', expect.anything());
       });
+      expect(mockOnSearch).toHaveBeenCalledWith('', expect.anything());
 
       expect(
         screen.queryByRole('row', {name: 'browser.name:firefox'})

static/app/utils/useDispatchingReducer.spec.tsx

@@ -53,8 +53,8 @@ describe('useDispatchingReducer', () => {
 
       await waitFor(() => {
         expect(reducer).toHaveBeenCalledTimes(1);
-        expect(result.current[0]).toEqual({type: 'action'});
       });
+      expect(result.current[0]).toEqual({type: 'action'});
     });
     it('calls before action with state and action args', () => {
       const initialState = {type: 'initial'};

static/app/utils/useProjectSdkNeedsUpdate.spec.tsx

@@ -54,9 +54,9 @@ describe('useProjectSdkNeedsUpdate', () => {
 
     await waitFor(() => {
       expect(result.current.isError).toBeFalsy();
-      expect(result.current.isFetching).toBeFalsy();
-      expect(result.current.needsUpdate).toBeFalsy();
     });
+    expect(result.current.isFetching).toBeFalsy();
+    expect(result.current.needsUpdate).toBeFalsy();
   });
 
   it('should be updated it the sdk version is too low', async () => {
@@ -77,9 +77,9 @@ describe('useProjectSdkNeedsUpdate', () => {
     });
     await waitFor(() => {
       expect(result.current.isError).toBeFalsy();
-      expect(result.current.isFetching).toBeFalsy();
-      expect(result.current.needsUpdate).toBeTruthy();
     });
+    expect(result.current.isFetching).toBeFalsy();
+    expect(result.current.needsUpdate).toBeTruthy();
   });
 
   it('should return needsUpdate if multiple projects', async () => {
@@ -105,9 +105,9 @@ describe('useProjectSdkNeedsUpdate', () => {
 
     await waitFor(() => {
       expect(result.current.isError).toBeFalsy();
-      expect(result.current.isFetching).toBeFalsy();
-      expect(result.current.needsUpdate).toBeTruthy();
     });
+    expect(result.current.isFetching).toBeFalsy();
+    expect(result.current.needsUpdate).toBeTruthy();
   });
 
   it('should not return needsUpdate if some projects meet minSdk', async () => {
@@ -133,8 +133,8 @@ describe('useProjectSdkNeedsUpdate', () => {
 
     await waitFor(() => {
       expect(result.current.isError).toBeFalsy();
-      expect(result.current.isFetching).toBeFalsy();
-      expect(result.current.needsUpdate).toBeFalsy();
     });
+    expect(result.current.isFetching).toBeFalsy();
+    expect(result.current.needsUpdate).toBeFalsy();
   });
 });

static/app/views/dashboards/dashboard.spec.tsx

@@ -295,8 +295,8 @@ describe('Dashboards > Dashboard', () => {
     await userEvent.click(await screen.findByText(/Switch to Transactions/));
     await waitFor(() => {
       expect(mockOnUpdate).toHaveBeenCalled();
-      expect(mockHandleUpdateWidgetList).toHaveBeenCalled();
     });
+    expect(mockHandleUpdateWidgetList).toHaveBeenCalled();
   });
 
   it('handles duplicate widget in view mode', async () => {

static/app/views/dashboards/detail.spec.tsx

@@ -1739,15 +1739,15 @@ describe('Dashboards > Detail', function () {
 
       await waitFor(() => {
         expect(mockPUT).toHaveBeenCalledTimes(1);
-        expect(mockPUT).toHaveBeenCalledWith(
-          '/organizations/org-slug/dashboards/1/',
-          expect.objectContaining({
-            data: expect.objectContaining({
-              permissions: {isEditableByEveryone: false, teamsWithEditAccess: []},
-            }),
-          })
-        );
       });
+      expect(mockPUT).toHaveBeenCalledWith(
+        '/organizations/org-slug/dashboards/1/',
+        expect.objectContaining({
+          data: expect.objectContaining({
+            permissions: {isEditableByEveryone: false, teamsWithEditAccess: []},
+          }),
+        })
+      );
     });
 
     it('creator can update permissions for dashboard', async function () {
@@ -1807,15 +1807,15 @@ describe('Dashboards > Detail', function () {
 
       await waitFor(() => {
         expect(mockPUT).toHaveBeenCalledTimes(1);
-        expect(mockPUT).toHaveBeenCalledWith(
-          '/organizations/org-slug/dashboards/1/',
-          expect.objectContaining({
-            data: expect.objectContaining({
-              permissions: {isEditableByEveryone: true, teamsWithEditAccess: []},
-            }),
-          })
-        );
       });
+      expect(mockPUT).toHaveBeenCalledWith(
+        '/organizations/org-slug/dashboards/1/',
+        expect.objectContaining({
+          data: expect.objectContaining({
+            permissions: {isEditableByEveryone: true, teamsWithEditAccess: []},
+          }),
+        })
+      );
     });
 
     it('creator can update permissions with teams for dashboard', async function () {
@@ -1891,15 +1891,15 @@ describe('Dashboards > Detail', function () {
 
       await waitFor(() => {
         expect(mockPUT).toHaveBeenCalledTimes(1);
-        expect(mockPUT).toHaveBeenCalledWith(
-          '/organizations/org-slug/dashboards/1/',
-          expect.objectContaining({
-            data: expect.objectContaining({
-              permissions: {isEditableByEveryone: false, teamsWithEditAccess: [1, 2]},
-            }),
-          })
-        );
       });
+      expect(mockPUT).toHaveBeenCalledWith(
+        '/organizations/org-slug/dashboards/1/',
+        expect.objectContaining({
+          data: expect.objectContaining({
+            permissions: {isEditableByEveryone: false, teamsWithEditAccess: [1, 2]},
+          }),
+        })
+      );
     });
 
     it('disables edit dashboard and add widget button if user cannot edit dashboard', async function () {

static/app/views/dashboards/manage/dashboardGrid.spec.tsx

@@ -201,8 +201,8 @@ describe('Dashboards - DashboardGrid', function () {
 
     await waitFor(() => {
       expect(deleteMock).toHaveBeenCalled();
-      expect(dashboardUpdateMock).toHaveBeenCalled();
     });
+    expect(dashboardUpdateMock).toHaveBeenCalled();
   });
 
   it('cannot delete last dashboard', async function () {
@@ -257,8 +257,8 @@ describe('Dashboards - DashboardGrid', function () {
 
     await waitFor(() => {
       expect(createMock).toHaveBeenCalled();
-      expect(dashboardUpdateMock).toHaveBeenCalled();
     });
+    expect(dashboardUpdateMock).toHaveBeenCalled();
   });
 
   it('does not throw an error if the POST fails during duplication', async function () {
@@ -291,9 +291,9 @@ describe('Dashboards - DashboardGrid', function () {
 
     await waitFor(() => {
       expect(postMock).toHaveBeenCalled();
-      // Should not update, and not throw error
-      expect(dashboardUpdateMock).not.toHaveBeenCalled();
     });
+    // Should not update, and not throw error
+    expect(dashboardUpdateMock).not.toHaveBeenCalled();
   });
 
   it('renders favorite and unfavorite buttons on cards', function () {

static/app/views/dashboards/manage/dashboardTable.spec.tsx

@@ -201,8 +201,8 @@ describe('Dashboards - DashboardTable', function () {
 
     await waitFor(() => {
       expect(deleteMock).toHaveBeenCalled();
-      expect(dashboardUpdateMock).toHaveBeenCalled();
     });
+    expect(dashboardUpdateMock).toHaveBeenCalled();
   });
 
   it('cannot delete last dashboard', function () {
@@ -251,8 +251,8 @@ describe('Dashboards - DashboardTable', function () {
 
     await waitFor(() => {
       expect(createMock).toHaveBeenCalled();
-      expect(dashboardUpdateMock).toHaveBeenCalled();
     });
+    expect(dashboardUpdateMock).toHaveBeenCalled();
   });
 
   it('does not throw an error if the POST fails during duplication', async function () {
@@ -282,9 +282,9 @@ describe('Dashboards - DashboardTable', function () {
 
     await waitFor(() => {
       expect(postMock).toHaveBeenCalled();
-      // Should not update, and not throw error
-      expect(dashboardUpdateMock).not.toHaveBeenCalled();
     });
+    // Should not update, and not throw error
+    expect(dashboardUpdateMock).not.toHaveBeenCalled();
   });
 
   it('renders access column', async function () {

static/app/views/dashboards/widgetBuilder/components/newWidgetBuilder.spec.tsx

@@ -200,9 +200,9 @@ describe('NewWidgetBuiler', function () {
     // see if alias field and add button are not there
     await waitFor(() => {
       expect(screen.queryByPlaceholderText('Legend Alias')).not.toBeInTheDocument();
-      expect(screen.queryByText('Add Filter')).not.toBeInTheDocument();
-      expect(screen.queryByLabelText('Remove this filter')).not.toBeInTheDocument();
     });
+    expect(screen.queryByText('Add Filter')).not.toBeInTheDocument();
+    expect(screen.queryByLabelText('Remove this filter')).not.toBeInTheDocument();
   });
 
   it('renders the group by field on chart widgets', async function () {

static/app/views/dashboards/widgetBuilder/components/widgetBuilderSlideout.spec.tsx

@@ -197,9 +197,9 @@ describe('WidgetBuilderSlideout', () => {
 
     await waitFor(() => {
       expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
-      expect(
-        screen.queryByText('You have unsaved changes. Are you sure you want to leave?')
-      ).not.toBeInTheDocument();
     });
+    expect(
+      screen.queryByText('You have unsaved changes. Are you sure you want to leave?')
+    ).not.toBeInTheDocument();
   });
 });