Skip to content

Commit

Permalink
Revert "feat(dev): Upgrade kafka and zookeeper to support Apple M1 (#…
Browse files Browse the repository at this point in the history
…28574)" (#28672)

This reverts commit b4bfb00.

Originally (see [originally reported issue](#28574 (comment))), instead of reverting my change, I landed a fix that only seems to work on Apple M1 (see fix #28724). Nevertheless, It seems that the *Intel* images would still fail with the same error (see issue #29022) with:
> Command [/usr/local/bin/dub path /var/lib/kafka/data writable] FAILED !

Let's revert it and I will try again later.

Fixes #29022
  • Loading branch information
armenzg authored Oct 4, 2021
1 parent e0a0b6a commit 28b48ee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
4 changes: 0 additions & 4 deletions .github/actions/setup-sentry/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,16 +158,12 @@ runs:
# TODO: Use devservices kafka. See https://github.com/getsentry/sentry/pull/20986#issuecomment-704510570
if [ "$NEED_KAFKA" = "true" ]; then
# This is *not* the production version. Unclear reason as to why this was chosen
# https://github.com/getsentry/ops/blob/c823e62f930ecc6c97bb08898c71e49edc7232f6/cookbooks/getsentry/attributes/default.rb#L631
docker run \
--name sentry_zookeeper \
-d --network host \
-e ZOOKEEPER_CLIENT_PORT=2181 \
confluentinc/cp-zookeeper:4.1.0
# This is the production version; do not change w/o changing it there as well
# https://github.com/getsentry/ops/blob/c823e62f930ecc6c97bb08898c71e49edc7232f6/cookbooks/getsentry/attributes/default.rb#L643
docker run \
--name sentry_kafka \
-d --network host \
Expand Down
7 changes: 2 additions & 5 deletions src/sentry/conf/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -1748,18 +1748,15 @@ def build_cdc_postgres_init_db_volume(settings):
),
"zookeeper": lambda settings, options: (
{
# Upgrading to version 6.x allows zookeeper to run properly on Apple's arm64
# See details https://github.com/confluentinc/kafka-images/issues/80#issuecomment-855511438
"image": "confluentinc/cp-zookeeper:6.2.0",
"image": "confluentinc/cp-zookeeper:5.1.2",
"environment": {"ZOOKEEPER_CLIENT_PORT": "2181"},
"volumes": {"zookeeper": {"bind": "/var/lib/zookeeper"}},
"only_if": "kafka" in settings.SENTRY_EVENTSTREAM or settings.SENTRY_USE_RELAY,
}
),
"kafka": lambda settings, options: (
{
# We upgrade to version 6.x to match zookeeper's version (I believe they both release together)
"image": "confluentinc/cp-kafka:6.2.0",
"image": "confluentinc/cp-kafka:5.1.2",
"ports": {"9092/tcp": 9092},
"environment": {
"KAFKA_ZOOKEEPER_CONNECT": "{containers[zookeeper][name]}:2181",
Expand Down

0 comments on commit 28b48ee

Please sign in to comment.