-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(demo-mode): passwordless login #83090
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83090 +/- ##
==========================================
+ Coverage 87.57% 87.62% +0.05%
==========================================
Files 9459 9440 -19
Lines 536794 536268 -526
Branches 21130 21047 -83
==========================================
- Hits 470086 469898 -188
+ Misses 66349 66011 -338
Partials 359 359 |
if email: | ||
return True | ||
|
||
return email in options.get("demo-mode.users") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this check short circuits the check whether the email is in the "demo-mode.users" option. It will return with True
whenever it is set to any non-empty string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests to ensure this all behaves as expected?
Context
sandbox
org https://sandbox.sentry.io/sandbox
org will be synced withdemo
org through sentry-mirrorsandbox
org and Demo User are behinddemo-mode.orgs
anddemo-mode.users
options respectively. Those options are added in PR