-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(demo-mode): passwordless login #83090
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83090 +/- ##
==========================================
+ Coverage 87.63% 87.68% +0.05%
==========================================
Files 9492 9455 -37
Lines 541325 538413 -2912
Branches 21234 21006 -228
==========================================
- Hits 474383 472123 -2260
+ Misses 66594 65933 -661
- Partials 348 357 +9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests to ensure this all behaves as expected?
It should be all covered with tests now :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Context
sandbox
org https://sandbox.sentry.io/sandbox
org will be synced withdemo
org through sentry-mirrorsandbox
org and Demo User are behinddemo-mode.orgs
anddemo-mode.users
options respectively. Those options are added in PR