ref(replays): update videoReplayer code to match new rrweb logic & bump rrweb version #71875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
reviewed
May 31, 2024
static/app/components/replays/videoReplayerWithInteractions.tsx
Outdated
Show resolved
Hide resolved
michellewzhang
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71875 +/- ##
==========================================
- Coverage 77.91% 77.89% -0.02%
==========================================
Files 6563 6570 +7
Lines 292299 292520 +221
Branches 50488 50517 +29
==========================================
+ Hits 227747 227871 +124
- Misses 58297 58395 +98
+ Partials 6255 6254 -1
|
billyvg
approved these changes
Jun 4, 2024
scttcper
reviewed
Jun 4, 2024
michellewzhang
changed the title
scttcper
approved these changes
Jun 4, 2024
michellewzhang
added
the
Trigger: Revert
|
PR reverted: 7ed3a13 |
getsentry-bot
added a commit
that referenced
this pull request
Jun 4, 2024
…gic & bump rrweb version (#71875)" This reverts commit 38b8050. Co-authored-by: michellewzhang <[email protected]>
billyvg
added a commit
that referenced
this pull request
Jun 10, 2024
redo of #71875 --------- Co-authored-by: Billy Vong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see getsentry/rrweb#190
we don't need this snippet anymore because we'll create pointers lazily.