feat(flags): Add splitio audit-log provider #79636
Conversation
github-actions
bot
added
the
Scope: Backend
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| raise InvalidProvider(provider) | ||
| if "previous" not in request_data: | ||
| action = ACTION_MAP["created"] | ||
| elif DELETED_REGEX.match(request_data["description"]): |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #79636 +/- ##
==========================================
- Coverage 78.45% 78.39% -0.07%
==========================================
Files 7141 7131 -10
Lines 315871 314944 -927
Branches 43462 43278 -184
==========================================
- Hits 247831 246911 -920
+ Misses 61721 61720 -1
+ Partials 6319 6313 -6 |
| "created_by_type": CREATED_BY_TYPE_MAP["name"], | ||
| "flag": request_data["name"], | ||
| "organization_id": organization_id, | ||
| "tags": {"environment": request_data["environmentName"]}, |
There was a problem hiding this comment.
should we standardize what we put in the tags? or does it not really matter?
i could add environment to the LD tags as well. looks like the splitio request body also has a description which i added to the LD tags intially
There was a problem hiding this comment.
A standard tag should just be a column. Tags are meant for unstructured data that could be displayed to the user but not otherwise can not be part of the structured record.
There was a problem hiding this comment.
We should keep a look out for noisy events unrelated to the flag's value (ex unleashed has a ton of "change request" events). Of course finding documentation on the schema/description of each event type would be great too, there just isn't any at https://help.split.io/ , as far as I can see 😥
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Adds split.io as a feature-flag provider.
Ref: https://github.com/getsentry/team-replay/issues/491