-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(grouping): Delete old configurations and snapshots #79677
base: master
Are you sure you want to change the base?
Conversation
We have migrated customers off from these configurations, thus, we should get rid of them. I'm leaving one last legacy configuration to reduce the number of changes in one pull request.
# into new grouping versions. | ||
|
||
register_strategy_config( | ||
id="legacy:2019-03-12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this configuration and all related snapshots.
initial_context={ | ||
"normalize_message": False, | ||
}, | ||
enhancements_base="legacy:2019-03-12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will remove the [email protected]
file.
|
||
# This is left behind in order to have less changes happen in one pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests depend on having a legacy configuration to update from.
register_strategy_config( | ||
id="newstyle:2019-10-29", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping this configuration and all related snapshots.
""", | ||
initial_context={ | ||
"php_detect_anonymous_classes": True, | ||
"with_context_line_file_origin_bug": False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know how we missed this one.
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
We have migrated customers away, thus, we can remove these.