Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grouping): Delete old configurations and snapshots #79677

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Oct 24, 2024

We have migrated customers away, thus, we can remove these.

We have migrated customers off from these configurations, thus, we should get rid of them.

I'm leaving one last legacy configuration to reduce the number of changes in one pull request.
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 24, 2024
@getsentry getsentry deleted a comment from github-actions bot Oct 24, 2024
@armenzg armenzg removed the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 24, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 24, 2024
# into new grouping versions.

register_strategy_config(
id="legacy:2019-03-12",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this configuration and all related snapshots.

initial_context={
"normalize_message": False,
},
enhancements_base="legacy:2019-03-12",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will remove the [email protected] file.


# This is left behind in order to have less changes happen in one pull request.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests depend on having a legacy configuration to update from.

register_strategy_config(
id="newstyle:2019-10-29",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping this configuration and all related snapshots.

""",
initial_context={
"php_detect_anonymous_classes": True,
"with_context_line_file_origin_bug": False,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will be moved to the latest configuration.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know how we missed this one.

@armenzg armenzg removed the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 24, 2024
@getsentry getsentry deleted a comment from codecov bot Oct 24, 2024
@getsentry getsentry deleted a comment from github-actions bot Oct 24, 2024
@armenzg armenzg marked this pull request as ready for review October 24, 2024 17:29
@armenzg armenzg requested review from a team as code owners October 24, 2024 17:29
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 24, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@getsantry
Copy link
Contributor

getsantry bot commented Nov 15, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Nov 15, 2024
@armenzg armenzg removed request for a team November 26, 2024 16:06
@getsantry
Copy link
Contributor

getsantry bot commented Dec 18, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Dec 18, 2024
@getsantry getsantry bot removed the Stale label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant