Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(issue-details): Allow event endpoint results to filter by query, date and environment #81471

Merged
merged 13 commits into from
Dec 19, 2024

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Nov 29, 2024

This will allow the new UI to filter the recommended, last, and first events by queries, dates, and environment. It also ensures the logic applies to the other issue types.

todo

  • Update tests
  • Add tests for different issue types

@leeandher leeandher requested review from a team as code owners November 29, 2024 20:25
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 15 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/issues/endpoints/group_event_details.py 65.85% 14 Missing ⚠️
src/sentry/models/group.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81471      +/-   ##
==========================================
- Coverage   80.43%   80.43%   -0.01%     
==========================================
  Files        7303     7303              
  Lines      321965   321986      +21     
  Branches    20991    20991              
==========================================
+ Hits       258976   258992      +16     
- Misses      62584    62589       +5     
  Partials      405      405              

@leeandher leeandher force-pushed the leander/return-no-event branch from 5bdc1fd to dd9e3a7 Compare December 17, 2024 22:19
@leeandher leeandher force-pushed the leander/return-no-event branch from dd9e3a7 to 6bfb3a4 Compare December 18, 2024 16:55
@leeandher leeandher requested review from scttcper and a team December 18, 2024 23:50
@leeandher leeandher marked this pull request as ready for review December 18, 2024 23:50
@leeandher leeandher changed the title ref(issue-details): Optionally allow event endpoint to return empty ref(issue-details): Allow event endpoint results to filter by query, date and environment Dec 18, 2024
@leeandher leeandher merged commit f138600 into master Dec 19, 2024
49 checks passed
@leeandher leeandher deleted the leander/return-no-event branch December 19, 2024 18:34
andrewshie-sentry pushed a commit that referenced this pull request Jan 2, 2025
…date and environment (#81471)

This will allow the new UI to filter the recommended, last, and first
events by queries, dates, and environment. It also ensures the logic
applies to the other issue types.

**todo**
- [x] Update tests
- [x] Add tests for different issue types
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants