Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traces): update to no instrumentation #82212

Closed
wants to merge 10 commits into from

Conversation

doralchan
Copy link
Contributor

@doralchan doralchan commented Dec 17, 2024

Before:
Screenshot 2024-12-16 at 4 39 45 PM
Screenshot 2024-12-16 at 4 42 04 PM

After:
Screenshot 2024-12-16 at 4 40 47 PM
Screenshot 2024-12-16 at 4 42 12 PM

@doralchan doralchan requested a review from a team as a code owner December 17, 2024 00:32
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8405 1 8404 0
View the top 1 failed tests by shortest run time
trace view pageload preferences toggles no instrumentation
Stack Traces | 1.79s run time
Error: expect(received).toBeInTheDocument()

received value must be an HTMLElement or an SVGElement.
Received has value: null

Ignored nodes: comments, script, style
...
    at __EXTERNAL_MATCHER_TRAP__ (.../expect/build/index.js:325:30)
    at Object.throwingMatcher [as toBeInTheDocument] (.../expect/build/index.js:326:15)
    at .../performance/newTraceDetails/trace.spec.tsx:1026:82
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/sentry/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/sentry/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:594:17)
    at processTimers (node:internal/timers:529:7)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@doralchan doralchan marked this pull request as draft December 17, 2024 01:21
@doralchan doralchan removed the request for review from a team December 17, 2024 01:21
@doralchan doralchan force-pushed the feat/trace-no-instrumentation branch from 8fc81a2 to 79aeac1 Compare December 17, 2024 16:37
@0Calories 0Calories added Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests and removed Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests labels Dec 17, 2024
@doralchan doralchan requested a review from JonasBa December 17, 2024 20:22
@doralchan
Copy link
Contributor Author

@JonasBa whenever you're feeling a little less dead, I think we might need some help on fixing this failing test

Copy link

codecov bot commented Dec 19, 2024

Bundle Report

Changes will increase total bundle size by 18.55kB (0.06%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 32.2MB 18.55kB (0.06%) ⬆️

@doralchan doralchan closed this Dec 19, 2024
@doralchan doralchan deleted the feat/trace-no-instrumentation branch December 19, 2024 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants