Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace-view): Info panel tab for new users #82408

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

0Calories
Copy link
Member

No description provided.

@0Calories 0Calories self-assigned this Dec 19, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
5195 5 5190 0
View the top 3 failed tests by shortest run time
trace view tabbing clicking on a node spawns a new tab when none is selected
Stack Traces | 0.465s run time
Error: expect(received).toHaveLength(expected)

Expected length: 1
Received length: 2
Received array:  [<li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><button class="css-1js4d2s-TabButton e1diyy3e5">Trace</button></li>, <li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><svg fill="currentColor" height="12px" style="margin-right: 2px;" viewBox="0 0 16 16" width="12px"><path d="M8,11.78A.74.74,0,0,1,7.24,11V7a.75.75,0,0,1,1.5,0v4A.75.75,0,0,1,8,11.78Z" /><circle cx="8" cy="4.78" r="0.76" /><path d="M8,16a8,8,0,1,1,8-8A8,8,0,0,1,8,16ZM8,1.53A6.47,6.47,0,1,0,14.47,8,6.47,6.47,0,0,0,8,1.53Z" /></svg><button class="css-1js4d2s-TabButton e1diyy3e5">Help</button></li>]
    at Object.<anonymous> (.../performance/newTraceDetails/trace.spec.tsx:1532:81)
trace view tabbing clicking a node that is already open in a tab switches to that tab and persists the previous node
Stack Traces | 0.468s run time
Error: expect(received).toHaveLength(expected)

Expected length: 1
Received length: 2
Received array:  [<li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><button class="css-1js4d2s-TabButton e1diyy3e5">Trace</button></li>, <li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><svg fill="currentColor" height="12px" style="margin-right: 2px;" viewBox="0 0 16 16" width="12px"><path d="M8,11.78A.74.74,0,0,1,7.24,11V7a.75.75,0,0,1,1.5,0v4A.75.75,0,0,1,8,11.78Z" /><circle cx="8" cy="4.78" r="0.76" /><path d="M8,16a8,8,0,1,1,8-8A8,8,0,0,1,8,16ZM8,1.53A6.47,6.47,0,1,0,14.47,8,6.47,6.47,0,0,0,8,1.53Z" /></svg><button class="css-1js4d2s-TabButton e1diyy3e5">Help</button></li>]
    at Object.<anonymous> (.../performance/newTraceDetails/trace.spec.tsx:1600:81)
trace view tabbing clicking on a node replaces the previously selected tab
Stack Traces | 0.508s run time
Error: expect(received).toHaveLength(expected)

Expected length: 1
Received length: 2
Received array:  [<li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><button class="css-1js4d2s-TabButton e1diyy3e5">Trace</button></li>, <li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><svg fill="currentColor" height="12px" style="margin-right: 2px;" viewBox="0 0 16 16" width="12px"><path d="M8,11.78A.74.74,0,0,1,7.24,11V7a.75.75,0,0,1,1.5,0v4A.75.75,0,0,1,8,11.78Z" /><circle cx="8" cy="4.78" r="0.76" /><path d="M8,16a8,8,0,1,1,8-8A8,8,0,0,1,8,16ZM8,1.53A6.47,6.47,0,1,0,14.47,8,6.47,6.47,0,0,0,8,1.53Z" /></svg><button class="css-1js4d2s-TabButton e1diyy3e5">Help</button></li>]
    at Object.<anonymous> (.../performance/newTraceDetails/trace.spec.tsx:1543:81)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@getsantry
Copy link
Contributor

getsantry bot commented Jan 10, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jan 10, 2025
@0Calories 0Calories added WIP and removed Stale labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant