Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): allow tooltip to be passed to transaction column headers #82588

Merged
merged 8 commits into from
Jan 3, 2025

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Dec 27, 2024

@DominikB2014 it was pretty quite in the office between Christmas and NYE, so I went ahead and did a little React programming. Please feel free to throw this out if I did everything wrong 😅

This adds the ability to pass tooltips to the insights column headers so we can give more context to users, see #82410

Screenshot 2024-12-27 at 2 20 04 PM

@bcoe bcoe requested a review from DominikB2014 December 27, 2024 19:24
@bcoe bcoe requested review from a team as code owners December 27, 2024 19:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 27, 2024
@bcoe bcoe requested a review from AbhiPrasad December 27, 2024 19:32
Copy link
Contributor

@DominikB2014 DominikB2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small nits and suggestions, but overall this lgtm, nothing blocking here imo!

static/app/views/performance/table.tsx Show resolved Hide resolved
static/app/views/performance/table.tsx Outdated Show resolved Hide resolved
static/app/views/performance/table.tsx Outdated Show resolved Hide resolved

This comment was marked as outdated.

Copy link

codecov bot commented Jan 2, 2025

Bundle Report

Changes will increase total bundle size by 1.76kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 32.07MB 1.76kB (0.01%) ⬆️

@bcoe bcoe merged commit 9e70134 into master Jan 3, 2025
42 checks passed
@bcoe bcoe deleted the tooltip-for-frontend branch January 3, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants