-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(insights): allow tooltip to be passed to transaction column headers #82588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Dec 27, 2024
DominikB2014
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small nits and suggestions, but overall this lgtm, nothing blocking here imo!
static/app/views/insights/pages/frontend/frontendOverviewPage.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominik Buszowiecki <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Bundle ReportChanges will increase total bundle size by 1.76kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DominikB2014 it was pretty quite in the office between Christmas and NYE, so I went ahead and did a little React programming. Please feel free to throw this out if I did everything wrong 😅
This adds the ability to pass tooltips to the insights column headers so we can give more context to users, see #82410